Skip to content

[hyperactor] Serialized: permit multiple encoding representations #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: gh/mariusae/35/base
Choose a base branch
from

Conversation

mariusae
Copy link
Member

@mariusae mariusae commented Aug 12, 2025

Stack from ghstack (oldest at bottom):

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: D80110110

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Aug 12, 2025
In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

ghstack-source-id: 302493173
Pull Request resolved: #832
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80110110

…tations"

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Aug 12, 2025
Pull Request resolved: #832

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!
ghstack-source-id: 302502853
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80110110

…tations"

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Aug 12, 2025
Pull Request resolved: #832

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 302535994

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80110110

…tations"

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Aug 13, 2025
Pull Request resolved: #832

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 302712692

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80110110

…tations"

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80110110

…tations"

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80110110

…tations"

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80110110

shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303723937

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303723937

Reviewed By: shayne-fletcher

Differential Revision: D80110110
…tations"

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".

Differential Revision: [D80110110](https://our.internmc.facebook.com/intern/diff/D80110110/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80110110/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80110110

shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
shayne-fletcher pushed a commit to shayne-fletcher/monarch-1 that referenced this pull request Aug 18, 2025
Summary:

In preparation for plumbing through multipart support, we extend Serialized to be representation polymorphic. This will allow us to add serde_multipart::Message as an encoding format, plumbing true multipart encoding "all the way down".
ghstack-source-id: 303814003

Reviewed By: shayne-fletcher

Differential Revision: D80110110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants